Remove cleanup step from setup-spiceio action#4
Merged
Conversation
The action should ensure spiceio is running (starting it if needed) and leave it running for the rest of the job, rather than killing it on completion.
There was a problem hiding this comment.
Pull request overview
This PR updates the local composite GitHub Action that installs and starts spiceio so it keeps the proxy running for subsequent job steps, rather than stopping it during the action execution.
Changes:
- Remove the cleanup step that stopped
spiceio. - Remove PID-related outputs/state (
pid,pid_file,skipped) that only supported cleanup. - Keep the action’s primary output limited to the
endpoint, while still performing readiness checks after starting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pidoutput andpid_file/skippedtracking that only existed to support cleanupThe setup action now ensures spiceio is running (starting it if needed) and leaves it running for the rest of the job.
Test plan